Permalink
Browse files

Explicit returns in rack servlet

  • Loading branch information...
1 parent 4e21ff1 commit b509d5905625b6a711d5a05c47dbecf34a5ea273 @dekellum committed Jul 29, 2011
Showing with 2 additions and 1 deletion.
  1. +2 −1 lib/mizuno/rack_servlet.rb
@@ -156,7 +156,7 @@ def servlet_to_rack(request)
env['rack.errors'] ||= $stderr
# All done, hand back the Rack request.
- return(env)
+ env
dekellum
dekellum Aug 13, 2011 Owner

Stylistic only (I tend to drop the "return" at normal method end)

end
#
@@ -230,6 +230,7 @@ def rack_to_servlet(rack_response, response)
# All done.
output.flush
+ false
dekellum
dekellum Aug 13, 2011 Owner

output.flush presumably returns nil which evals false? But "false" (or return "false" ) is a good deal more explicit here.

end
end
end

0 comments on commit b509d59

Please sign in to comment.