Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for interation with other annotation processors #283 #284

Merged
merged 2 commits into from Aug 26, 2019

Conversation

@noelo
Copy link
Contributor

commented Jul 20, 2019

No description provided.

@iocanel

This comment has been minimized.

Copy link
Collaborator

commented Jul 23, 2019

following up our discussion in #283 I think that there is no issue in using dekorate along with other processors.

However, I see value in documenting the approach on adding the processors as part of the compiler plugin and its benefits.

@noelo

This comment has been minimized.

Copy link
Contributor Author

commented Jul 23, 2019

Great, just checking do you need me to do anything with this ?

@iocanel iocanel self-requested a review Jul 26, 2019

@iocanel
Copy link
Collaborator

left a comment

Using multiple annoation processors is doable without maven-compliler-plugin configuration.

This approach, makes sense when you need to be explicit about the processors, or when you need to use processosrs without messing with the classpath.

We could adjust this commit in order to highlight the benefits of defining processors as part fo the maven-compiler-plugin configuration.

noelo added a commit to noelo/dekorate that referenced this pull request Aug 11, 2019

@noelo noelo force-pushed the noelo:master branch from 2de01b6 to 30dc1d5 Aug 11, 2019

@iocanel
Copy link
Collaborator

left a comment

LGTM

@iocanel iocanel merged commit 8e44847 into dekorateio:master Aug 26, 2019

1 check passed

build_and_test Workflow: build_and_test
Details

@aureamunoz aureamunoz added this to the 0.8.2 milestone Aug 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.