New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delegate to `ActiveSupport::Logger` instead of `Logger` if Rails version > 3 #77

Merged
merged 2 commits into from Nov 8, 2017

Conversation

Projects
None yet
4 participants
@Crunch09
Contributor

Crunch09 commented Oct 31, 2017

This defaults delegating to ActiveSupport::Logger if available so we can use methods like #silence.

This fixes #76

@codecov

This comment has been minimized.

codecov bot commented Oct 31, 2017

Codecov Report

Merging #77 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #77      +/-   ##
==========================================
+ Coverage   92.93%   92.96%   +0.03%     
==========================================
  Files          90       90              
  Lines        2434     2445      +11     
==========================================
+ Hits         2262     2273      +11     
  Misses        172      172
Impacted Files Coverage Δ
spec/roo_on_rails/logger_spec.rb 100% <100%> (ø) ⬆️
lib/roo_on_rails/logger.rb 97.87% <100%> (+0.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 648ce6c...539b62e. Read the comment docs.

@jphastings jphastings merged commit 4376472 into master Nov 8, 2017

14 checks passed

ci/circleci: build_2.2.6_rails_3 Your tests passed on CircleCI!
Details
ci/circleci: build_2.2.6_rails_4 Your tests passed on CircleCI!
Details
ci/circleci: build_2.2.6_rails_5 Your tests passed on CircleCI!
Details
ci/circleci: build_2.2.6_rails_5_1 Your tests passed on CircleCI!
Details
ci/circleci: build_2.3.3_rails_3 Your tests passed on CircleCI!
Details
ci/circleci: build_2.3.3_rails_4 Your tests passed on CircleCI!
Details
ci/circleci: build_2.3.3_rails_5 Your tests passed on CircleCI!
Details
ci/circleci: build_2.3.3_rails_5_1 Your tests passed on CircleCI!
Details
ci/circleci: build_2.4.0_rails_4 Your tests passed on CircleCI!
Details
ci/circleci: build_2.4.0_rails_5 Your tests passed on CircleCI!
Details
ci/circleci: build_2.4.0_rails_5_1 Your tests passed on CircleCI!
Details
codeclimate All good!
Details
codecov/patch 100% of diff hit (target 92.93%)
Details
codecov/project 92.96% (+0.03%) compared to 648ce6c
Details

@jphastings jphastings deleted the fix_quit_assets branch Nov 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment