ASM-9277 Do not #read a closed file handle, File.read instead #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll look at this |
ripienaar
commented
Mar 8, 2017
| @@ -222,7 +222,7 @@ | |||
| it "should raise an error when install_from_uri job fails" do | |||
| data = {:name => "xyz", :description => "test file"}.to_json | |||
| data.stubs(:path).returns("/tmp") | |||
| data.stubs(:read).returns("tmp") | |||
| File.stubs(:read).with("/tmp").returns("tmp") | |||
There was a problem hiding this comment.
@logankimmel you do kind of test the unhappy path but stub too much so the problem got hidden :) not really always a good way to stub these file things so it is what it is.
|
this coverage decrease is because I added lines but did not add more tests - the line is tested. |
|
@gavin-scott should be mergable now |
|
Nice find, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.