Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[KRV-2486] Fix gounity dependency #56

Merged
merged 2 commits into from Jan 24, 2022
Merged

[KRV-2486] Fix gounity dependency #56

merged 2 commits into from Jan 24, 2022

Conversation

panigs7
Copy link
Collaborator

@panigs7 panigs7 commented Jan 12, 2022 •
edited

Description

Fix for gounity dependency errors due to lint, format, vet issues fixes in gounity.
PR dependent on dell/gounity#17

GitHub Issue #
dell/csm#128

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
CSI unity driver was successfully installed and a sanity test was run.

rensyct
rensyct previously approved these changes Jan 12, 2022
View reviewed changes
rensyct
rensyct reviewed Jan 12, 2022
View reviewed changes
Copy link
Contributor

@rensyct rensyct left a comment •
edited by panigs7

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some more checks that are failing still

Checked

@rensyct rensyct self-requested a review January 12, 2022 12:56
karthikk92
karthikk92 previously approved these changes Jan 12, 2022
View reviewed changes
@panigs7 panigs7 dismissed stale reviews from karthikk92 and rensyct via 2637e34 January 17, 2022 11:52
@panigs7 panigs7 force-pushed the fix-gounity-dependency branch 4 times, most recently from 1ccce27 to b50c2ed Compare January 19, 2022 08:32
rensyct
rensyct previously approved these changes Jan 19, 2022
View reviewed changes
@panigs7 panigs7 dismissed stale reviews from rajendraindukuri and rensyct via 10c5b56 January 20, 2022 15:04
@panigs7 panigs7 force-pushed the fix-gounity-dependency branch 2 times, most recently from 10c5b56 to 51cad7f Compare January 21, 2022 05:22
@rajendraindukuri rajendraindukuri merged commit ffc61ce into main Jan 24, 2022
@karthikk92 karthikk92 deleted the fix-gounity-dependency branch March 21, 2022 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajendraindukuri rajendraindukuri rajendraindukuri approved these changes

@karthikk92 karthikk92 karthikk92 approved these changes

@rensyct rensyct rensyct left review comments

@bandak2 bandak2 Awaiting requested review from bandak2 bandak2 is a code owner

@francis-nijay francis-nijay Awaiting requested review from francis-nijay francis-nijay is a code owner

@gallacher gallacher Awaiting requested review from gallacher

@prasar6 prasar6 Awaiting requested review from prasar6

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@panigs7 @rensyct @rajendraindukuri @karthikk92