flash-msg.js may not work correctly when there is no flash message HTML

[delphidabbler]

Experimentation with cookies showed a cookie name of dd_flash_undefined was being tested for.

This implies that perhaps the code that detects for the absence of the flash-popup id is not working. Possibly the following test never evaluates true:

delphidabbler.github.io/assets/scripts/flash-msg.js

Line 9 in 881bc60

if ( ! flash )

flash is set in the previous line:

delphidabbler.github.io/assets/scripts/flash-msg.js

Line 8 in 881bc60

var flash = $("#flash-popup");

If certain Jekyll variables are set then the flash HTML should not be present and so the flash-popup id should not be present.

The only way I can see that a dd_flash_undefined cookie name can be built is if flash.data('flash-id') returns undefined in the following code:

var id = flash.data('flash-id');
var cookieName = 'dd_flash_' + id;

Getting to this code should be impossible when there is no HTML.

So, this code needs to be checked.

[delphidabbler]

I misunderstood how jQuery notifies a selector it doesn't find. I assumes $("#flash-popup") would return falsy if #flash-popup was not found.

What actually happens is that a valid object is returned with zero length.

So need to change the test:

if ( ! flash )

to

if ( flash.length === 0 )

[delphidabbler]

Will actually fix this bug while implementing fix required by issue #129