Skip to content

Use "delphix/actions" for shfmt #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2020
Merged

Use "delphix/actions" for shfmt #223

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions .github/scripts/install-shfmt.sh
View file
Open in desktop

This file was deleted.

3 changes: 1 addition & 2 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,5 +118,4 @@ jobs:
runs-on: ubuntu-18.04
steps:
- uses: actions/checkout@v2
- run: ./.github/scripts/install-shfmt.sh
- run: /usr/local/bin/shfmt -d .
- uses: delphix/actions/shfmt@master
Copy link
Contributor

@pzakha pzakha May 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't also run shellcheck for sdb?

Copy link
Contributor Author

@prakashsurya prakashsurya May 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see it used anywhere in this repository, do you? Did I overlook something?

Copy link
Contributor

@pzakha pzakha May 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I meant that as a generic question. @sdimitro Is there an explicit reason we aren't running shellcheck? Should we add it?

Copy link
Contributor

@sdimitro sdimitro May 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No explicit reason - I just only knew about shfmt at the time when I made that change :-)

Copy link
Contributor

@pzakha pzakha May 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, we can perhaps consider adding it in a later commit.