Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more test tables and update integration tests #36

Merged
merged 4 commits into from Jun 5, 2021
Merged

Conversation

zsxwing
Copy link
Member

@zsxwing zsxwing commented Jun 5, 2021

Add two more tables and update existing integration tests accordingly:

  • share3.default.table4: The table column order is not the same as parquet files.
  • share3.default.table5: An empty table.

@zsxwing zsxwing requested a review from ueshin June 5, 2021 00:35
@zsxwing
Copy link
Member Author

zsxwing commented Jun 5, 2021

@FX196 is fixing the empty table issue. I'm adding these tables so that he can write end-to-end tests for empty table.

@FX196
Copy link
Collaborator

FX196 commented Jun 5, 2021

Thanks @zsxwing ! I was going to write the empty tables test myself

Copy link
Collaborator

@ueshin ueshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zsxwing zsxwing merged commit eac84d4 into main Jun 5, 2021
@zsxwing zsxwing deleted the add-test-tables branch June 5, 2021 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants