[Spark] Make listDeltaCompactedDeltaCheckpointFilesAndLatestChecksumFile reusable #3157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumeet-db
reviewed
May 28, 2024
| * Run the test against a [[TrackingCommitOwnerClient]] with backfill batch size = | ||
| * `batchBackfillSize` | ||
| */ | ||
| def testWithTrackingInMemoryCommitOwner( |
There was a problem hiding this comment.
The other users of this utils class won't fully understand different commit owner implementations etc. Should we call it def testWithManagedCommits( instead?
There was a problem hiding this comment.
Sounds good, updated.
sumeet-db
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
Factors out the main logic from
listDeltaCompactedDeltaCheckpointFilesAndLatestChecksumFileinto a new functionlistFromFileSystemInternalwhich can potentially be reused by other callers. Also added a new test utility which runs tests with in-memory-tracking commit owner enabled.How was this patch tested?
Existing tests should cover this.
Does this PR introduce any user-facing changes?
No