Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for G Suite domains #1626

Merged
merged 1 commit into from
Jun 17, 2020
Merged

Add support for G Suite domains #1626

merged 1 commit into from
Jun 17, 2020

Conversation

mmoya
Copy link
Collaborator

@mmoya mmoya commented Jun 16, 2020

Do a lookup based on domain's MX servers. G Suite domains are expected
to have at least 'aspmx.l.google.com' listed in MXs.

See https://support.google.com/a/answer/140034

fixes #1425

Cargo.lock Outdated Show resolved Hide resolved
Copy link
Member

@dignifiedquire dignifiedquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice small diff :)

Do a lookup based on domain's MX servers. G Suite domains are expected
to have at least 'aspmx.l.google.com' listed in MXs.

See https://support.google.com/a/answer/140034

fixes #1425
src/oauth2.rs Show resolved Hide resolved
src/oauth2.rs Show resolved Hide resolved
src/oauth2.rs Show resolved Hide resolved
src/oauth2.rs Show resolved Hide resolved
src/oauth2.rs Show resolved Hide resolved
@link2xt link2xt merged commit b5fa0f8 into master Jun 17, 2020
@link2xt link2xt deleted the gsuite-domains branch June 17, 2020 08:50
@rrthomas
Copy link

Brilliant, many thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Detecting G Suite domains for OAuth2 flow
4 participants