fix: avoid manual poll impl for accounts events #1944
Conversation
There was a problem hiding this comment.
This is a busy loop consuming 100% CPU now, as it never .awaits.
One of the solutions I can think of is to remove try_recv() completely and use select_all on a list of recv futures.
dignifiedquire
force-pushed
the
fix-accounts-events
branch
from
e47a0ec
to
cc87f06
Compare
|
thanks @link2xt should be good now |
|
But now if the first emitter is not finished yet, and only the second emitter has something, it will keep awaiting the first one without starting to await the second one. I don't think it can be solved without select. |
src/accounts.rs
Outdated
| } | ||
| Err(async_std::sync::TryRecvError::Empty) => {} | ||
| for e in &self.0 { | ||
| if let Some(event) = e.emitter.recv().await { |
There was a problem hiding this comment.
This will never start recv future for the second emitter, until the first emitter returns None.
I don't think select will work either, at least not naively, because there is a chance we will miss events, if two are ready at the same time |
Then there is a stream version of |
|
@link2xt yes that was the right one, I think it works now |
dignifiedquire
changed the title
Fixes #1922