Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete Message should have a confirm dialog #1083

Closed
Simon-Laux opened this issue Oct 26, 2019 · 7 comments
Assignees

Comments

@Simon-Laux
Copy link
Member

@Simon-Laux Simon-Laux commented Oct 26, 2019

Because It's easy to click on it on accident. happened to me two times recently while using the touch-pad.

@violoncelloCH

This comment has been minimized.

Copy link

@violoncelloCH violoncelloCH commented Oct 26, 2019

How about an option to easily undo a deletion instead of an (annoying) confirmation dialog?
Just an undo option which is there for e.g. 20s before the message is completely removed...

@Simon-Laux

This comment has been minimized.

Copy link
Member Author

@Simon-Laux Simon-Laux commented Oct 26, 2019

I agree that this would be better, but it is much more coding effort.
What about a shift click to skip the conformation dialog instead?

@Simon-Laux

This comment has been minimized.

Copy link
Member Author

@Simon-Laux Simon-Laux commented Oct 26, 2019

telegram has a conformation dialog, too. I don't think it is too annoying.

@r10s

This comment has been minimized.

Copy link
Member

@r10s r10s commented Oct 26, 2019

i agree with @Simon-Laux, i would just add a normal ask-deletion-dialog, no shift-workarounds or so.

@violoncelloCH we're currently in release-mode, we do not want to add much code and/or complexity, we just want to get things stable :) if you like, however, you can suggest an "undo" or so in the forum.

@hansal7014

This comment has been minimized.

Copy link
Contributor

@hansal7014 hansal7014 commented Oct 26, 2019

Hi,
Please can I work on this issue?
Thanks.

@Simon-Laux

This comment has been minimized.

Copy link
Member Author

@Simon-Laux Simon-Laux commented Oct 26, 2019

@hansal7014 yeah of course go for it. If you have questions feel free to post them here in this issue.

@Simon-Laux

This comment has been minimized.

Copy link
Member Author

@Simon-Laux Simon-Laux commented Oct 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.