Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1083 - Add confirm delete message dialog. #1090

Merged
merged 4 commits into from Oct 30, 2019
Merged

Fixes #1083 - Add confirm delete message dialog. #1090

merged 4 commits into from Oct 30, 2019

Conversation

hansal7014
Copy link
Contributor

What changes are being made? (feature/bug)

Adds a confirm delete message dialog that is shown to the user before deleting any messages.

Why are these changes necessary? Link any related issues

As outlined in issue #1083, it is very easy for the user to press the delete message option without having the chance to undo such an operation. The confirm delete message dialog will prompt the user to confirm the delete operation or cancel it.

Unit Test

Copy link
Contributor

@nicodh nicodh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very useful! Thanks!

src/renderer/components/message/MessageList.js Outdated Show resolved Hide resolved
Copy link
Member

@Simon-Laux Simon-Laux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's merge it
Edit: after ci tests are done

@Simon-Laux Simon-Laux merged commit 820d3dc into deltachat:master Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants