Add read-only mode for US users #1574
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
6 Skipped Deployments
|
ryangoree
changed the title
There was a problem hiding this comment.
Even though this is more than the hook, I opted to put it in /hooks since that's the only way it's meant to be used outside of the single provider in App. I consider the context an implementation detail.
DannyDelott
left a comment
DannyDelott
left a comment
There was a problem hiding this comment.
Excited to have a read-only mode 🎉
| const region = new URL(window.location.href).searchParams | ||
| .get("region") | ||
| ?.toLocaleLowerCase(); |
There was a problem hiding this comment.
Can we use add a validateSearch to the home route and use useSearch({ from: "/" }) instead? It'd be nice to have the source of truth for all search params live next to the routes.
There was a problem hiding this comment.
The router provider lives in App, so the hooks can't be used here. But I think that's ok since we really shouldn't be referencing this search param outside of this function. The hook is the only source of truth since it will ensure the context persists through route changes.
The PR adds a new
RegionInfocontext, provider, and hook which checks the URL query string for aregionvalue against a list of read-only regions. This query parameter will automatically be added to requests at the edge via Cloudflare.Screen.Recording.2024-10-14.at.4.25.34.PM.mov