Skip to content

Conversation

@jackburrus
Copy link
Contributor

@jackburrus jackburrus commented Oct 21, 2024

This PR adds a manage dropdown for existing long positions allowing users to either open a new long in this market, or close the current one.

Screen.Recording.2024-10-21.at.10.55.58.AM.mov

Closes #1567

@changeset-bot
Copy link

changeset-bot bot commented Oct 21, 2024

⚠️ No Changeset found

Latest commit: b217f65

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hyperdrive-mainnet-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2024 5:11pm
hyperdrive-sepolia-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2024 5:11pm
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
hyperdrive-js ⬜️ Ignored (Inspect) Visit Preview Oct 25, 2024 5:11pm
hyperdrive-mainnet-production ⬜️ Ignored (Inspect) Visit Preview Oct 25, 2024 5:11pm
hyperdrive-sepolia-production ⬜️ Ignored (Inspect) Visit Preview Oct 25, 2024 5:11pm
testnet-v1 ⬜️ Ignored (Inspect) Oct 25, 2024 5:11pm
testnet-v1.0.6 ⬜️ Ignored (Inspect) Visit Preview Oct 25, 2024 5:11pm
trading-competition ⬜️ Ignored (Inspect) Visit Preview Oct 25, 2024 5:11pm

Copy link
Contributor

@DannyDelott DannyDelott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

}}
search={{ position: "longs" }}
>
Open Long
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor: Let's label this as Go to pool instead.

).showModal();
}}
>
Close Long
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like this should be above "Go to pool" as it's the primary management action for an open position

@jackburrus jackburrus merged commit fc69157 into main Oct 25, 2024
14 checks passed
@jackburrus jackburrus deleted the update-manage-buttons branch October 25, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make Manage Button a dropdown in Longs

3 participants