Naive LP Allocation and Withdrawal Schemes #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jalextowle
force-pushed
the
jalextowle/hyperdrive/simple-lp-scheme
branch
from
8265e34 to
4985591
Compare
jrhea
added a commit
that referenced
this pull request
Mar 4, 2024
…enBondsInDerivativeSafe` (#786) * Avoid unnecessary subtraction in `calculateSharesOutGivenBondsInDerivativeSafe` * Applied the fix on the other line --------- Co-authored-by: Jonny Rhea <5555162+jrhea@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a naive LP allocation scheme that is safe but not fair, and a withdrawal scheme that gives the withdrawing LP no exposure to returns on the open trades that they facilitated. These schemes can be summed up as:
Additionally, this PR brings in several contracts from the
protocol_v2repository that provides a way for ERC20 interfaces to be deployed over an ERC1155-like token. This is used instead of ERC1155Mintable and OpenZeppelin's ERC20 implementation.