Skip to content

Conversation

@Padraic-O-Mhuiris
Copy link
Contributor

@Padraic-O-Mhuiris Padraic-O-Mhuiris commented Feb 8, 2023

This change includes the decoding of the asset id as it was constructed and a minor change in how the encoding of the timestamp was constructed.

@Padraic-O-Mhuiris Padraic-O-Mhuiris changed the title decodeAssetId() and fix modulus operation decodeAssetId() and fix timestamp encoding Feb 8, 2023
@Padraic-O-Mhuiris Padraic-O-Mhuiris merged commit 8dfb4f8 into main Feb 8, 2023
@Padraic-O-Mhuiris Padraic-O-Mhuiris deleted the decode-asset-id branch February 8, 2023 15:19
jalextowle added a commit that referenced this pull request Feb 26, 2024
* Avoided double-counting the fee in `openLong`

* Renamed `bondProceeds` to `bondReservesDelta` for consistency in `openLong`
jalextowle added a commit that referenced this pull request Feb 27, 2024
* Avoided double-counting the fee in `openLong`

* Renamed `bondProceeds` to `bondReservesDelta` for consistency in `openLong`
jalextowle added a commit that referenced this pull request Feb 29, 2024
* Avoided double-counting the fee in `openLong`

* Renamed `bondProceeds` to `bondReservesDelta` for consistency in `openLong`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants