Struct-less solution to viaIR #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

Padraic-O-Mhuiris merged 40 commits into main from via-ir-2

Feb 14, 2023

Contributor

Padraic-O-Mhuiris commented Feb 10, 2023

No description provided.

Padraic-O-Mhuiris force-pushed the via-ir-2 branch from ae20af8 to 81641f3 Compare

February 10, 2023 10:30

Padraic-O-Mhuiris marked this pull request as ready for review

February 10, 2023 10:44

Padraic-O-Mhuiris requested review from aleph-v, jalextowle and sentilesdal

February 10, 2023 18:51

jalextowle reviewed

View reviewed changes

.github/workflows/coverage.yml Show resolved Hide resolved

jalextowle reviewed

View reviewed changes

.gitignore Show resolved Hide resolved

jalextowle reviewed

View reviewed changes

README.md Outdated Show resolved Hide resolved

jalextowle reviewed

View reviewed changes

contracts/libraries/HyperdriveMath.sol Outdated Show resolved Hide resolved

jalextowle reviewed

View reviewed changes

contracts/libraries/HyperdriveMath.sol Outdated Show resolved Hide resolved

jalextowle reviewed

View reviewed changes

contracts/libraries/HyperdriveMath.sol Outdated Show resolved Hide resolved

jalextowle reviewed

View reviewed changes

contracts/libraries/YieldSpaceMath.sol Outdated Show resolved Hide resolved

jalextowle reviewed

View reviewed changes

contracts/libraries/YieldSpaceMath.sol Show resolved Hide resolved

jalextowle reviewed

View reviewed changes

contracts/libraries/YieldSpaceMath.sol Show resolved Hide resolved

jalextowle reviewed

View reviewed changes

contracts/libraries/YieldSpaceMath.sol Outdated Show resolved Hide resolved

aleph-v reviewed

View reviewed changes

Contributor

aleph-v left a comment

I'd really like to see more comments and ideally porting tests from the original repo for this code to ensure that it has the same behavior.

Padraic-O-Mhuiris requested review from aleph-v and jalextowle

February 13, 2023 21:20

jalextowle reviewed

View reviewed changes

contracts/libraries/YieldSpaceMath.sol Outdated Show resolved Hide resolved

jalextowle approved these changes

View reviewed changes

Contributor

jalextowle left a comment

One nit that should be fixed before merging, and then it LGTM.

Padraic-O-Mhuiris added 10 commits

February 14, 2023 16:00


          struct less solution to viaIR

f30ede0


          add workflow for coverage

e5093a1


          add node in workflow

7e73423


          update


          update

4771c68


          update


          use codecov

c28148b


          remove comments

5b57682


          update

852f21c


          added comment?

e2ff78f

Padraic-O-Mhuiris and others added 25 commits

February 14, 2023 16:00


          comment

8a41e97


          update

604ce90

fix

7144f16


          update

2259cb3


          linting

52f9b89


          update

866189a


          use coveralls instead of codecov

22bc766


          update

85d5470


          test

4172cf8


          update

60935a0

fix

96889da


          add comments to .gitignore

1e7af28


          fix coverage badge link

d2d8e49


          add test badge

7ce781f


          Update contracts/libraries/HyperdriveMath.sol

a0de0f4

Co-authored-by: Alex Towle <jalextowle@gmail.com>


          Update contracts/libraries/HyperdriveMath.sol

b860fc6

Co-authored-by: Alex Towle <jalextowle@gmail.com>


          Update contracts/libraries/HyperdriveMath.sol

da99d3c

Co-authored-by: Alex Towle <jalextowle@gmail.com>


          relabel parameters in consistency with HyperdriveMath

c92173c


          added comments for _k

3495bbc


          add comments back in

5612bfb


          prettier

e99dc4e

fix

30e8a1c


          workflows

749d0e0


          calculateOutGivenIn tests

396e2b8


          use tau instead of t

969eb01

Padraic-O-Mhuiris force-pushed the via-ir-2 branch from 8640973 to 969eb01 Compare

February 14, 2023 16:01


          update flake

d793f99

Padraic-O-Mhuiris merged commit 7658bcc into main

Padraic-O-Mhuiris deleted the via-ir-2 branch

February 14, 2023 16:14

jalextowle added a commit that referenced this pull request


          Spearbit #56: Safely cast from uint256 to int128 or int256 (#812)

ea1d45b

* Use `SafeCast` from `uint256` to `int256`

* Use `SafeCast` when casting from `uint256` to `int128`

* Use `SafeCast` in `FixedPointMath`

* Fixed the Rust tests

* Fixed the rust tests (again)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet