Skip to content

Simple Hyperdrive Tests #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 35 commits into from
Feb 15, 2023
Merged

Simple Hyperdrive Tests #59

merged 35 commits into from
Feb 15, 2023

Conversation

@jalextowle
Copy link
Contributor

@jalextowle jalextowle commented Feb 11, 2023 •
edited
Loading

Adds simple unit tests that test the Hyperdrive trading flows.

@jalextowle jalextowle changed the base branch from main to jalextowle/hyperdrive/share-price-checkpointing February 11, 2023 23:11
@jalextowle jalextowle force-pushed the jalextowle/tests/simple-hyperdrive-tests branch from 696a04e to 9d93131 Compare February 12, 2023 00:03
@jalextowle jalextowle force-pushed the jalextowle/tests/simple-hyperdrive-tests branch from 9d93131 to 0de5d3a Compare February 12, 2023 04:00
@jalextowle jalextowle force-pushed the jalextowle/tests/simple-hyperdrive-tests branch from fe3858c to 302ddff Compare February 12, 2023 21:25
@jalextowle jalextowle force-pushed the jalextowle/hyperdrive/share-price-checkpointing branch from 733d983 to d11364a Compare February 12, 2023 21:50
@jalextowle jalextowle force-pushed the jalextowle/tests/simple-hyperdrive-tests branch from 76b5b14 to 47dc823 Compare February 12, 2023 21:50
@jalextowle jalextowle mentioned this pull request Feb 13, 2023
Closed
@coveralls
Copy link
Collaborator

coveralls commented Feb 14, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4188711346

  • 3 of 21 (14.29%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+21.7%) to 24.896%
Changes Missing Coverage Covered Lines Changed/Added Lines %
contracts/libraries/AssetId.sol 0 2 0.0%
contracts/Hyperdrive.sol 3 10 30.0%
contracts/libraries/HyperdriveMath.sol 0 9 0.0%
Files with Coverage Reduction New Missed Lines %
contracts/libraries/HyperdriveMath.sol 1 0%
Totals Coverage Status
Change from base Build 4187422012: 21.7%
Covered Lines: 120
Relevant Lines: 482
💛 - Coveralls

Base automatically changed from jalextowle/hyperdrive/share-price-checkpointing to main February 15, 2023 04:01
@jalextowle jalextowle marked this pull request as ready for review February 15, 2023 22:10
jrhea
jrhea approved these changes Feb 15, 2023
View reviewed changes
Copy link
Contributor

@jrhea jrhea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jalextowle jalextowle merged commit 9c377ab into main Feb 15, 2023
@jalextowle jalextowle deleted the jalextowle/tests/simple-hyperdrive-tests branch February 15, 2023 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jrhea jrhea jrhea approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jalextowle @coveralls @jrhea