Test the zero amount case for addLiquidity #66
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Pull Request Test Coverage Report for Build 4189191908
💛 - Coveralls |
jalextowle
approved these changes
Feb 16, 2023
Contributor
jalextowle
left a comment
jalextowle
left a comment
There was a problem hiding this comment.
If we're going to change the style of the test names, can we do it universally? Doesn't need to be in this PR btw.
jalextowle
changed the title
jalextowle
added a commit
that referenced
this pull request
Mar 7, 2024
…ath` (#822) * Use safe functions more consistently in `calculateNetCurveTradeSafe` * Fail if `calculateSharesOutGivenBondsInDownSafe` underflows * Fixed the rust tests * Improved the system's liveness when the present value can't be computed * Improved the liveness properties of `removeLiquidity` * Ignore `calculateLPSharePrice` failures in `removeLiquidity` * Ensure that the ending indexes are valid in `HyperdriveFactory` getters * Used unchecked arithmetic in several places * Made the `LPMath` safer and used unchecked arithmetic * Use unchecked arithmetic in the rest of the contracts * Consolidated the derivative functions in the `LPMath` library * Addressed review feedback from @jrhea * Simplified the main loop of `calculateDistributeExcessIdle`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A one-off test that ensures that
addLiquiditywill fail if called with a zero amount.