Skip to content

Warning mitigations #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Feb 16, 2023
Merged

Warning mitigations #67

merged 9 commits into from
Feb 16, 2023

Conversation

@Padraic-O-Mhuiris
Copy link
Contributor

@Padraic-O-Mhuiris Padraic-O-Mhuiris commented Feb 16, 2023 •
edited
Loading

This PR:

  • Extends number of _arr functions to include up to 10 uint256 or uint256[] arguments for the combinatorial test framework
  • Removes unused _positionDuration from AaveYieldSource.sol
  • Fixes warnings arising from shadowed variable declarations in Test.sol
  • Adds production profile in foundry config which includes deny_warnings = true so that compilations will fail if warnings exist.
  • Adds a "build" ci workflow to run an optimized build with via-ir and strict warning settings

@coveralls
Copy link
Collaborator

coveralls commented Feb 16, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4194483093

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 25.294%
Totals Coverage Status
Change from base Build 4190538067: 0.0%
Covered Lines: 129
Relevant Lines: 510
💛 - Coveralls

@Padraic-O-Mhuiris Padraic-O-Mhuiris changed the title Warnings Warning mitigations Feb 16, 2023
@Padraic-O-Mhuiris Padraic-O-Mhuiris requested review from aleph-v and jalextowle and removed request for aleph-v February 16, 2023 13:35
@Padraic-O-Mhuiris Padraic-O-Mhuiris merged commit eb5d349 into main Feb 16, 2023
@Padraic-O-Mhuiris Padraic-O-Mhuiris deleted the fix-all-warnings branch February 16, 2023 15:13
@jalextowle jalextowle mentioned this pull request Feb 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jalextowle jalextowle Awaiting requested review from jalextowle

1 more reviewer

@aleph-v aleph-v aleph-v approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Padraic-O-Mhuiris @coveralls @aleph-v