-
Notifications
You must be signed in to change notification settings - Fork 6
stETH Integration #718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stETH Integration #718
Conversation
Hyperdrive Gas Benchmark
This comment was automatically generated by workflow using github-action-benchmark. |
5e288e7 to
6f4a2dd
Compare
contracts/src/deployers/erc4626/ERC4626HyperdriveCoreDeployer.sol
Outdated
Show resolved
Hide resolved
jrhea
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. I'm surprised that there was no gas savings, any idea why that is?
jrhea
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This PR implements a direct stETH integration. Most of the code for this integration was able to be taken from commits prior to #454. This PR accomplishes two primary goals:
Aside from implementing the stETH integration, this PR also re-organized the
instancesdirectory. In particular, instances are now grouped into sub-folders, and there is a new directory calleddeployerswhich contains the deployer implementations for each instance.In addition to these other changes, this PR implements the infrastructure that will be required to run a testnet with both a stETH and an sDAI pool.