Skip to content

Conversation

@jalextowle
Copy link
Contributor

@DannyDelott Reported an issue on Monday that he couldn't access the getPoolConfig function on the StETHHyperdrive instance deployed by the DevnetMigration.s.sol script. After investigating the issue, I found that theer was no bytecode stored at the stethHyperdrive address. Since the last release, we added create2 to the deployment, and from reading through Foundry's open issues, there are a number of issues relating to create2 deployments in Foundry scripts and tests. With this in mind, I decided to re-write the migration script in Rust to fix the issue. It appears that this worked.

@jalextowle jalextowle requested a review from jrhea February 1, 2024 02:06
@github-actions
Copy link

github-actions bot commented Feb 1, 2024

Hyperdrive Gas Benchmark

Benchmark suite Current: e1c1650 Previous: 6a5956c Deviation Status
addLiquidity: min 1546 gas 1546 gas 0% 🟰
addLiquidity: avg 68291 gas 66602 gas 2.5360% 🚨
addLiquidity: max 292728 gas 292728 gas 0% 🟰
checkpoint: min 1150 gas 1150 gas 0% 🟰
checkpoint: avg 48153 gas 48195 gas -0.0871%
checkpoint: max 191173 gas 191173 gas 0% 🟰
closeLong: min 1492 gas 1492 gas 0% 🟰
closeLong: avg 28456 gas 28417 gas 0.1372% 🚨
closeLong: max 148543 gas 152268 gas -2.4463%
closeShort: min 1494 gas 1494 gas 0% 🟰
closeShort: avg 30196 gas 30252 gas -0.1851%
closeShort: max 129747 gas 146093 gas -11.1888%
initialize: min 1495 gas 1495 gas 0% 🟰
initialize: avg 213307 gas 213307 gas 0% 🟰
initialize: max 253585 gas 253585 gas 0% 🟰
openLong: min 1432 gas 1432 gas 0% 🟰
openLong: avg 50742 gas 50750 gas -0.0158%
openLong: max 187405 gas 187405 gas 0% 🟰
openShort: min 1520 gas 1520 gas 0% 🟰
openShort: avg 50018 gas 49950 gas 0.1361% 🚨
openShort: max 180144 gas 180144 gas 0% 🟰
redeemWithdrawalShares: min 1488 gas 1488 gas 0% 🟰
redeemWithdrawalShares: avg 20854 gas 20276 gas 2.8507% 🚨
redeemWithdrawalShares: max 108516 gas 108516 gas 0% 🟰
removeLiquidity: min 1552 gas 1552 gas 0% 🟰
removeLiquidity: avg 151283 gas 149237 gas 1.3710% 🚨
removeLiquidity: max 324881 gas 324881 gas 0% 🟰

This comment was automatically generated by workflow using github-action-benchmark.

@jalextowle jalextowle force-pushed the jalextowle/fix/migration-script branch from dbcc71a to e1c1650 Compare February 1, 2024 08:05
@jalextowle jalextowle merged commit ced8d53 into main Feb 1, 2024
@jalextowle jalextowle deleted the jalextowle/fix/migration-script branch February 1, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants