Skip to content

Conversation

@jalextowle
Copy link
Contributor

@jalextowle jalextowle commented Feb 21, 2024

Addresses Spearbit Issue #70.

Aside from fixing the Spearbit issue, this PR also adds test coverage for all of the other routes that utilize the destination field.

@jalextowle jalextowle requested a review from jrhea February 21, 2024 05:04
Copy link
Contributor

@jrhea jrhea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one nit

@jalextowle jalextowle enabled auto-merge (squash) February 22, 2024 01:30
@github-actions
Copy link

Hyperdrive Gas Benchmark

Benchmark suite Current: d5d29aa Previous: 9adc3d7 Deviation Status
addLiquidity: min 1546 gas 1546 gas 0% 🟰
addLiquidity: avg 68565 gas 68654 gas -0.1296%
addLiquidity: max 293159 gas 293159 gas 0% 🟰
checkpoint: min 1150 gas 1150 gas 0% 🟰
checkpoint: avg 48192 gas 48359 gas -0.3453%
checkpoint: max 191173 gas 191173 gas 0% 🟰
closeLong: min 1492 gas 1492 gas 0% 🟰
closeLong: avg 29271 gas 29242 gas 0.0992% 🚨
closeLong: max 150226 gas 152215 gas -1.3067%
closeShort: min 1494 gas 1494 gas 0% 🟰
closeShort: avg 31149 gas 31101 gas 0.1543% 🚨
closeShort: max 146908 gas 131308 gas 11.8805% 🚨
initialize: min 1451 gas 1451 gas 0% 🟰
initialize: avg 213931 gas 213693 gas 0.1114% 🚨
initialize: max 253953 gas 253953 gas 0% 🟰
openLong: min 1499 gas 1499 gas 0% 🟰
openLong: avg 51588 gas 51516 gas 0.1398% 🚨
openLong: max 185666 gas 185666 gas 0% 🟰
openShort: min 1520 gas 1520 gas 0% 🟰
openShort: avg 51269 gas 51153 gas 0.2268% 🚨
openShort: max 181325 gas 181325 gas 0% 🟰
redeemWithdrawalShares: min 1488 gas 1488 gas 0% 🟰
redeemWithdrawalShares: avg 21948 gas 20810 gas 5.4685% 🚨
redeemWithdrawalShares: max 109301 gas 109296 gas 0.0046% 🚨
removeLiquidity: min 1530 gas 1530 gas 0% 🟰
removeLiquidity: avg 151328 gas 151470 gas -0.0937%
removeLiquidity: max 325781 gas 325648 gas 0.0408% 🚨

This comment was automatically generated by workflow using github-action-benchmark.

@jalextowle jalextowle merged commit bdd97cf into main Feb 22, 2024
@jalextowle jalextowle deleted the jalextowle/audit/spearbit-70 branch February 22, 2024 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants