Skip to content

Conversation

@jalextowle
Copy link
Contributor

Addresses Spearbit Issue #77. Specifically, this PR applies changes requested by @Saw-mon-and-Natalie here: #768 (comment).

@jalextowle jalextowle requested a review from jrhea February 23, 2024 02:38
@jalextowle jalextowle changed the title Applied a fix requested by @saw-mon-and-natalie for Spearbit issue #77 Spearbit #77: Applied a fix requested by @saw-mon-and-natalie Feb 23, 2024
@github-actions
Copy link

Hyperdrive Gas Benchmark

Benchmark suite Current: a24ec95 Previous: 38123c5 Deviation Status
addLiquidity: min 1546 gas 1546 gas 0% 🟰
addLiquidity: avg 68726 gas 67075 gas 2.4614% 🚨
addLiquidity: max 293159 gas 293159 gas 0% 🟰
checkpoint: min 1182 gas 1182 gas 0% 🟰
checkpoint: avg 48498 gas 48566 gas -0.1400%
checkpoint: max 191559 gas 191559 gas 0% 🟰
closeLong: min 1492 gas 1492 gas 0% 🟰
closeLong: avg 29448 gas 29320 gas 0.4366% 🚨
closeLong: max 149358 gas 152215 gas -1.8770%
closeShort: min 1494 gas 1494 gas 0% 🟰
closeShort: avg 33317 gas 33420 gas -0.3082%
closeShort: max 133556 gas 149177 gas -10.4715%
initialize: min 1451 gas 1451 gas 0% 🟰
initialize: avg 213932 gas 213932 gas 0% 🟰
initialize: max 253953 gas 253953 gas 0% 🟰
openLong: min 1499 gas 1499 gas 0% 🟰
openLong: avg 51751 gas 51696 gas 0.1064% 🚨
openLong: max 185666 gas 185666 gas 0% 🟰
openShort: min 1520 gas 1520 gas 0% 🟰
openShort: avg 51364 gas 51434 gas -0.1361%
openShort: max 181325 gas 181325 gas 0% 🟰
redeemWithdrawalShares: min 1488 gas 1488 gas 0% 🟰
redeemWithdrawalShares: avg 22161 gas 21936 gas 1.0257% 🚨
redeemWithdrawalShares: max 109301 gas 109301 gas 0% 🟰
removeLiquidity: min 1530 gas 1530 gas 0% 🟰
removeLiquidity: avg 150118 gas 152880 gas -1.8066%
removeLiquidity: max 325781 gas 325781 gas 0% 🟰

This comment was automatically generated by workflow using github-action-benchmark.

@jalextowle jalextowle merged commit 9caae4a into main Feb 26, 2024
@jalextowle jalextowle deleted the jalextowle/audit/spearbit-77-part-2 branch February 26, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants