Skip to content

Spearbit #37: Addressed the fix to the factory requested by Spearbit #773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 28, 2024
Merged

Spearbit #37: Addressed the fix to the factory requested by Spearbit #773

merged 4 commits into from
Feb 28, 2024

Conversation

@jalextowle
Copy link
Contributor

@jalextowle jalextowle commented Feb 23, 2024

Addresses Spearbit Issue #37.

@github-actions
Copy link

github-actions bot commented Feb 23, 2024 •
edited
Loading

Hyperdrive Gas Benchmark

Benchmark suite Current: 15d53fa Previous: 38123c5 Deviation Status
addLiquidity: min 33974 gas 1546 gas 2097.5420% 🚨
addLiquidity: avg 142826 gas 67075 gas 112.9348% 🚨
addLiquidity: max 336771 gas 293159 gas 14.8766% 🚨
checkpoint: min 29265 gas 1182 gas 2375.8883% 🚨
checkpoint: avg 106507 gas 48566 gas 119.3036% 🚨
checkpoint: max 199040 gas 191559 gas 3.9053% 🚨
closeLong: min 31333 gas 1492 gas 2000.0670% 🚨
closeLong: avg 95252 gas 29320 gas 224.8704% 🚨
closeLong: max 217386 gas 152215 gas 42.8151% 🚨
closeShort: min 31335 gas 1494 gas 1997.3896% 🚨
closeShort: avg 94197 gas 33420 gas 181.8582% 🚨
closeShort: max 193488 gas 149177 gas 29.7036% 🚨
initialize: min 31350 gas 1451 gas 2060.5789% 🚨
initialize: avg 248531 gas 213932 gas 16.1729% 🚨
initialize: max 319421 gas 253953 gas 25.7796% 🚨
openLong: min 33415 gas 1499 gas 2129.1528% 🚨
openLong: avg 124233 gas 51696 gas 140.3145% 🚨
openLong: max 245881 gas 185666 gas 32.4319% 🚨
openShort: min 33820 gas 1520 gas 2125% 🚨
openShort: avg 135750 gas 51434 gas 163.9305% 🚨
openShort: max 250833 gas 181325 gas 38.3334% 🚨
redeemWithdrawalShares: min 46854 gas 1488 gas 3048.7903% 🚨
redeemWithdrawalShares: avg 72195 gas 21936 gas 229.1165% 🚨
redeemWithdrawalShares: max 142873 gas 109301 gas 30.7152% 🚨
removeLiquidity: min 31183 gas 1530 gas 1938.1046% 🚨
removeLiquidity: avg 192529 gas 152880 gas 25.9347% 🚨
removeLiquidity: max 325861 gas 325781 gas 0.0246% 🚨

This comment was automatically generated by workflow using github-action-benchmark.

@jalextowle jalextowle requested a review from jrhea February 24, 2024 01:02
jrhea
jrhea reviewed Feb 26, 2024
View reviewed changes
jrhea
jrhea approved these changes Feb 26, 2024
View reviewed changes
Copy link
Contributor

@jrhea jrhea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one nit

@jrhea jrhea enabled auto-merge (squash) February 28, 2024 17:26
@jrhea jrhea merged commit 1b09a11 into main Feb 28, 2024
@jrhea jrhea deleted the jalextowle/audit/spearbit-37 branch February 28, 2024 21:33
jalextowle added a commit that referenced this pull request Feb 29, 2024
@jalextowle @jrhea
Spearbit #37: Addressed the fix to the factory requested by Spearbit (#…
0aedd53 
…773)

* Addressed the fix to the factory requested by Spearbit

* Update contracts/src/libraries/Constants.sol

---------

Co-authored-by: Jonny Rhea <5555162+jrhea@users.noreply.github.com>
jalextowle added a commit that referenced this pull request Feb 29, 2024
@jalextowle @jrhea
Spearbit #37: Addressed the fix to the factory requested by Spearbit (#…
30a06d3 
…773)

* Addressed the fix to the factory requested by Spearbit

* Update contracts/src/libraries/Constants.sol

---------

Co-authored-by: Jonny Rhea <5555162+jrhea@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jrhea jrhea jrhea approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jalextowle @jrhea