Skip to content

Spearbit #67: Removed unneeded memory access in calculateDistributeExcessIdleShareProceedsNetLongEdgeCase #794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 2, 2024
Merged

Spearbit #67: Removed unneeded memory access in calculateDistributeExcessIdleShareProceedsNetLongEdgeCase #794

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d1deb8d
Removed unneeded memory access in `calculateDistributeExcessIdleShare…
jalextowle Feb 27, 2024
ed5cdda
Merge branch 'main' into jalextowle/audit/spearbit-67
jrhea Mar 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions contracts/src/libraries/LPMath.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -830,12 +830,7 @@ library LPMath {
return (0, false);
}

// Calculate the net flat trade using the original reserves.
_params.presentValueParams.shareReserves = _params
.originalShareReserves;
_params.presentValueParams.shareAdjustment = _params
.originalShareAdjustment;
_params.presentValueParams.bondReserves = _params.originalBondReserves;
// Calculate the net flat trade.
int256 netFlatTrade = calculateNetFlatTrade(_params.presentValueParams);

// NOTE: Round up since this is the rhs of the final subtraction.
Expand Down