Skip to content

Spearbit #40: Fixed a potential signature replay vulnerability #804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 5, 2024
Merged

Spearbit #40: Fixed a potential signature replay vulnerability #804

merged 1 commit into from
Mar 5, 2024

Conversation

@jalextowle
Copy link
Contributor

@jalextowle jalextowle commented Feb 29, 2024

Addresses Spearbit Issue #40.

@jalextowle jalextowle requested a review from jrhea February 29, 2024 05:47
@github-actions
Copy link

github-actions bot commented Feb 29, 2024 •
edited
Loading

Hyperdrive Gas Benchmark

Benchmark suite Current: f8ba263 Previous: 46c834d Deviation Status
addLiquidity: min 34062 gas 1546 gas 2103.2342% 🚨
addLiquidity: avg 142603 gas 67936 gas 109.9079% 🚨
addLiquidity: max 357772 gas 293159 gas 22.0403% 🚨
checkpoint: min 29254 gas 1182 gas 2374.9577% 🚨
checkpoint: avg 106450 gas 48477 gas 119.5887% 🚨
checkpoint: max 199029 gas 191559 gas 3.8996% 🚨
closeLong: min 31422 gas 1492 gas 2006.0322% 🚨
closeLong: avg 99507 gas 29374 gas 238.7588% 🚨
closeLong: max 217462 gas 152303 gas 42.7825% 🚨
closeShort: min 31335 gas 1494 gas 1997.3896% 🚨
closeShort: avg 98144 gas 33444 gas 193.4577% 🚨
closeShort: max 193886 gas 149156 gas 29.9887% 🚨
initialize: min 31328 gas 1451 gas 2059.0627% 🚨
initialize: avg 248523 gas 213962 gas 16.1529% 🚨
initialize: max 319487 gas 253953 gas 25.8056% 🚨
openLong: min 33503 gas 1499 gas 2135.0233% 🚨
openLong: avg 126489 gas 51658 gas 144.8585% 🚨
openLong: max 248173 gas 185562 gas 33.7413% 🚨
openShort: min 33798 gas 1520 gas 2123.5526% 🚨
openShort: avg 135980 gas 51482 gas 164.1312% 🚨
openShort: max 250994 gas 181325 gas 38.4222% 🚨
redeemWithdrawalShares: min 46854 gas 1488 gas 3048.7903% 🚨
redeemWithdrawalShares: avg 72118 gas 22375 gas 222.3151% 🚨
redeemWithdrawalShares: max 142865 gas 109301 gas 30.7079% 🚨
removeLiquidity: min 31161 gas 1530 gas 1936.6667% 🚨
removeLiquidity: avg 194999 gas 151225 gas 28.9463% 🚨
removeLiquidity: max 326079 gas 325781 gas 0.0915% 🚨

This comment was automatically generated by workflow using github-action-benchmark.

jrhea
jrhea reviewed Mar 2, 2024
View reviewed changes
jrhea
jrhea approved these changes Mar 2, 2024
View reviewed changes
Copy link
Contributor

@jrhea jrhea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one nit

@jalextowle jalextowle force-pushed the jalextowle/audit/spearbit-40 branch from d840882 to f8ba263 Compare March 5, 2024 20:05
@jalextowle jalextowle enabled auto-merge (squash) March 5, 2024 20:06
@jalextowle jalextowle merged commit e03e3f4 into main Mar 5, 2024
@jalextowle jalextowle deleted the jalextowle/audit/spearbit-40 branch March 5, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jrhea jrhea jrhea approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jalextowle @jrhea