Spearbit #89: Addressed review feedback from @saw-mon-and-natalie

[jalextowle]

Addresses feedback on Spearbit Issue #89.

[jrhea]

i'm going to stand down on this one. i shouldnt have approved and merged the last one

[github-actions]

Hyperdrive Gas Benchmark

Benchmark suite	Current: 587d9f5	Previous: 46c834d	Deviation	Status
addLiquidity: min	33893 gas	1546 gas	2092.3027%	🚨
addLiquidity: avg	146909 gas	67936 gas	116.2462%	🚨
addLiquidity: max	402101 gas	293159 gas	37.1614%	🚨
checkpoint: min	29254 gas	1182 gas	2374.9577%	🚨
checkpoint: avg	107858 gas	48477 gas	122.4931%	🚨
checkpoint: max	210819 gas	191559 gas	10.0543%	🚨
closeLong: min	31450 gas	1492 gas	2007.9088%	🚨
closeLong: avg	100365 gas	29374 gas	241.6797%	🚨
closeLong: max	227465 gas	152303 gas	49.3503%	🚨
closeShort: min	31327 gas	1494 gas	1996.8541%	🚨
closeShort: avg	99888 gas	33444 gas	198.6724%	🚨
closeShort: max	198404 gas	149156 gas	33.0178%	🚨
initialize: min	31283 gas	1451 gas	2055.9614%	🚨
initialize: avg	249104 gas	213962 gas	16.4244%	🚨
initialize: max	320422 gas	253953 gas	26.1737%	🚨
openLong: min	33503 gas	1499 gas	2135.0233%	🚨
openLong: avg	130083 gas	51658 gas	151.8158%	🚨
openLong: max	251848 gas	185562 gas	35.7218%	🚨
openShort: min	33870 gas	1520 gas	2128.2895%	🚨
openShort: avg	138576 gas	51482 gas	169.1737%	🚨
openShort: max	361823 gas	181325 gas	99.5439%	🚨
redeemWithdrawalShares: min	31205 gas	1488 gas	1997.1102%	🚨
redeemWithdrawalShares: avg	71985 gas	22375 gas	221.7207%	🚨
redeemWithdrawalShares: max	150203 gas	109301 gas	37.4214%	🚨
removeLiquidity: min	31213 gas	1530 gas	1940.0654%	🚨
removeLiquidity: avg	221560 gas	151225 gas	46.5102%	🚨
removeLiquidity: max	365657 gas	325781 gas	12.2401%	🚨

This comment was automatically generated by workflow using github-action-benchmark.

[Saw-mon-and-Natalie]

Looks good. Just need to make sure

• the change to the direction of the inequality propagate to the head of the branch
• tests pass