max long comment cleanup #830
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpaiton
force-pushed
the
dpaiton/max-long-cleanup
branch
from
62d9385 to
ad45bda
Compare
7 tasks
jalextowle
reviewed
Mar 8, 2024
jalextowle
reviewed
Mar 8, 2024
jalextowle
approved these changes
Mar 8, 2024
Contributor
jalextowle
left a comment
jalextowle
left a comment
There was a problem hiding this comment.
LGTM once the nits are addressed and a PR description is added.
dpaiton
force-pushed
the
dpaiton/max-long-cleanup
branch
from
ad45bda to
994be87
Compare
dpaiton
added a commit
that referenced
this pull request
Mar 28, 2024
* remove extra z_min * remove extra fee eqn * add note about inverse price * fix bug with solvency calculation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #774