Improved the sweep function #836
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrhea
reviewed
Mar 11, 2024
jrhea
approved these changes
Mar 11, 2024
Hyperdrive Gas Benchmark
This comment was automatically generated by workflow using github-action-benchmark. |
dpaiton
pushed a commit
that referenced
this pull request
Mar 28, 2024
* Updated the `sweep` function so that it is implemented in `Hyperdrive` * Allows governance to update the fee and sweep collector * Fixed the rust tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
sweepfunction to reduce code duplication. In addition to movesweepintoHyperdrive.sol, this PR also makes it possible for governance to update the fee collector of a deployed pool and for governance to set a target to receive any swept funds.