Skip to content

Conversation

@jalextowle
Copy link
Contributor

This PR adds more comprehensive liveness checks throughout the codebase. This will further reduce the chance of arithmetic errors resulting in liveness failures during the checkpoint process.

@jalextowle jalextowle requested a review from jrhea March 17, 2024 19:10
@github-actions
Copy link

github-actions bot commented Mar 17, 2024

Hyperdrive Gas Benchmark

Benchmark suite Current: be7db4b Previous: 46c834d Deviation Status
addLiquidity: min 33915 gas 1546 gas 2093.7257% 🚨
addLiquidity: avg 145249 gas 67936 gas 113.8027% 🚨
addLiquidity: max 405253 gas 293159 gas 38.2366% 🚨
checkpoint: min 29232 gas 1182 gas 2373.0964% 🚨
checkpoint: avg 104031 gas 48477 gas 114.5987% 🚨
checkpoint: max 211255 gas 191559 gas 10.2819% 🚨
closeLong: min 31428 gas 1492 gas 2006.4343% 🚨
closeLong: avg 132805 gas 29374 gas 352.1175% 🚨
closeLong: max 299549 gas 152303 gas 96.6796% 🚨
closeShort: min 31349 gas 1494 gas 1998.3266% 🚨
closeShort: avg 127886 gas 33444 gas 282.3885% 🚨
closeShort: max 201614 gas 149156 gas 35.1699% 🚨
initialize: min 31283 gas 1451 gas 2055.9614% 🚨
initialize: avg 252987 gas 213962 gas 18.2392% 🚨
initialize: max 322173 gas 253953 gas 26.8632% 🚨
openLong: min 33503 gas 1499 gas 2135.0233% 🚨
openLong: avg 167010 gas 51658 gas 223.2994% 🚨
openLong: max 252525 gas 185562 gas 36.0866% 🚨
openShort: min 33848 gas 1520 gas 2126.8421% 🚨
openShort: avg 169860 gas 51482 gas 229.9406% 🚨
openShort: max 363609 gas 181325 gas 100.5289% 🚨
redeemWithdrawalShares: min 31227 gas 1488 gas 1998.5887% 🚨
redeemWithdrawalShares: avg 63424 gas 22375 gas 183.4592% 🚨
redeemWithdrawalShares: max 161936 gas 109301 gas 48.1560% 🚨
removeLiquidity: min 31323 gas 1530 gas 1947.2549% 🚨
removeLiquidity: avg 219446 gas 151225 gas 45.1122% 🚨
removeLiquidity: max 376082 gas 325781 gas 15.4401% 🚨

This comment was automatically generated by workflow using github-action-benchmark.

@jalextowle jalextowle force-pushed the jalextowle/fix/liveness-fixes branch from caf10dc to d4d5265 Compare March 17, 2024 23:27
jalextowle added a commit that referenced this pull request Mar 18, 2024
@jalextowle jalextowle force-pushed the jalextowle/fix/liveness-fixes branch from d4d5265 to c5eaacb Compare March 18, 2024 02:44
jalextowle added a commit that referenced this pull request Mar 18, 2024
@jalextowle jalextowle force-pushed the jalextowle/fix/liveness-fixes branch from c5eaacb to 7b058ab Compare March 18, 2024 02:45
@jalextowle jalextowle force-pushed the jalextowle/fix/liveness-fixes branch from 7b058ab to 97e41de Compare March 18, 2024 02:47
@jalextowle jalextowle enabled auto-merge (squash) March 18, 2024 03:01
@jalextowle jalextowle merged commit d264165 into main Mar 18, 2024
@jalextowle jalextowle deleted the jalextowle/fix/liveness-fixes branch March 18, 2024 04:49
dpaiton pushed a commit that referenced this pull request Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants