Fix the testnet publish failures #852
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jalextowle
force-pushed
the
jalextowle/fix/testnet-publish
branch
2 times, most recently
from
f950ca8 to
0fa3f74
Compare
jalextowle
force-pushed
the
jalextowle/fix/testnet-publish
branch
from
db0540a to
a82aea5
Compare
jalextowle
changed the title
jrhea
approved these changes
Mar 19, 2024
dpaiton
pushed a commit
that referenced
this pull request
Mar 28, 2024
* Debug the testnet publish failures * Added some debugging statements * More debugging * More debugging * Fixed the problem with the testnet script * Disabled testnet publish in pull requests * Included the `sweepCollector` in the Rust deployment tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issues experienced trying to publish the testnet docker images for
v0.10.0. The issue that was causing this was that the docker image didn't accept the fee parameters as environment variables, so the overridden flat fee parameters that I added weren't making it to the publish script. This was fixed, and in addition, I added all of the other variables from the migration script's configuration that were missing.