-
Notifications
You must be signed in to change notification settings - Fork 6
Add getters for immutables for LsETH and rETH #863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
6b72526
Added reth getters
cashd 368ece2
update reth getter function scope
cashd 9341f63
add lseth getters
cashd 87edc6a
comment cleanup
cashd 5ab9134
RETH getter comments
cashd 9b4b7e7
lseth comments
cashd e32b93a
added getter test for steth
cashd f307425
Update RETHHyperdrive.t.sol
cashd b592328
renamed file mac
cashd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
| pragma solidity 0.8.20; | ||
|
|
||
| import { IHyperdrive } from "./IHyperdrive.sol"; | ||
| import { IRETHHyperdriveRead } from "./IRETHHyperdriveRead.sol"; | ||
|
|
||
| interface IRETHHyperdrive is IHyperdrive, IRETHHyperdriveRead {} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
| pragma solidity 0.8.20; | ||
|
|
||
| import { IHyperdriveRead } from "./IHyperdriveRead.sol"; | ||
| import { IRocketStorage } from "./IRocketStorage.sol"; | ||
| import { IRocketTokenRETH } from "./IRocketTokenRETH.sol"; | ||
|
|
||
| interface IRETHHyperdriveRead is IHyperdriveRead { | ||
| /// @notice Gets the Rocket Storage contract. | ||
| /// @return The Rocket Storage contract. | ||
| function rocketStorage() external view returns (IRocketStorage); | ||
|
|
||
| /// @notice Gets the Rocket Token rETH contract. | ||
| /// @return The Rocket Token rETH contract. | ||
| function rocketTokenRETH() external view returns (IRocketTokenRETH); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
| pragma solidity 0.8.20; | ||
|
|
||
| import { IHyperdrive } from "../IHyperdrive.sol"; | ||
| import { ILsETHHyperdriveRead } from "./ILsETHHyperdriveRead.sol"; | ||
|
|
||
| interface ILsETHHyperdrive is IHyperdrive, ILsETHHyperdriveRead {} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
| pragma solidity 0.8.20; | ||
|
|
||
| import { IHyperdriveRead } from "../IHyperdriveRead.sol"; | ||
| import { IRiverV1 } from "./IRiverV1.sol"; | ||
|
|
||
| interface ILsETHHyperdriveRead is IHyperdriveRead { | ||
| /// @notice Gets the LsETH token contract. | ||
| /// @return The LsETH token contract. | ||
| function lsEth() external view returns (IRiverV1); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.