Refactor the assertions for close long #89
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Pull Request Test Coverage Report for Build 4227251506
💛 - Coveralls |
jalextowle
force-pushed
the
jalextowle/tests/refactor-assertions-close-long
branch
2 times, most recently
from
3b5e962 to
216e43e
Compare
sentilesdal
approved these changes
Feb 20, 2023
* Refactored the assertions for open short * Refactored the assertions for the short close short * Added a TODO for the error bar
jalextowle
force-pushed
the
jalextowle/tests/refactor-assertions-close-long
branch
from
2407cde to
2974f01
Compare
jalextowle
deleted the
jalextowle/tests/refactor-assertions-close-long
branch
jrhea
added a commit
that referenced
this pull request
Mar 3, 2024
…g edge case of distribute excess idle (#800) * Removed unneeded memory access in `calculateDistributeExcessIdleShareProceedsNetLongEdgeCase` * Cleaned up the `calculateDistributeExcessIdleShareProceedsNetLongEdgeCaseSafe` function and its usage --------- Co-authored-by: Jonny Rhea <5555162+jrhea@users.noreply.github.com>
jalextowle
added a commit
that referenced
this pull request
Mar 7, 2024
* Use safe functions more consistently in `calculateNetCurveTradeSafe` * Fail if `calculateSharesOutGivenBondsInDownSafe` underflows * Fixed the rust tests * Improved the system's liveness when the present value can't be computed * Improved the liveness properties of `removeLiquidity` * Ignore `calculateLPSharePrice` failures in `removeLiquidity` * Ensure that the ending indexes are valid in `HyperdriveFactory` getters * Used unchecked arithmetic in several places * Made the `LPMath` safer and used unchecked arithmetic * Use unchecked arithmetic in the rest of the contracts * Consolidated the derivative functions in the `LPMath` library * Addressed review feedback from @jrhea * Simplified the main loop of `calculateDistributeExcessIdle` * Addressed review feedback from @Saw-mon-and-Natalie * Addressed review feedback from @Saw-mon-and-Natalie
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up the close long tests by abstracting out the assertions as much as possible. The assertion about the amount of capital the long receives is intentionally left out to add flexibility to the assertion.