Refactor assertions in the short tests #90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jalextowle
force-pushed
the
jalextowle/tests/refactor-assertions-close-long
branch
from
3b5e962 to
216e43e
Compare
jalextowle
force-pushed
the
jalextowle/tests/refactor-assertions-shorts
branch
from
573c1c7 to
300d59a
Compare
sentilesdal
approved these changes
Feb 20, 2023
Contributor
sentilesdal
left a comment
sentilesdal
left a comment
There was a problem hiding this comment.
looks good, double check this assert
jalextowle
added a commit
that referenced
this pull request
Feb 20, 2023
* Refactored the assertions for open short * Refactored the assertions for the short close short * Added a TODO for the error bar
jalextowle
added a commit
that referenced
this pull request
Feb 20, 2023
* Refactored the close long tests * Refactor assertions in the short tests (#90) * Refactored the assertions for open short * Refactored the assertions for the short close short * Added a TODO for the error bar * Fixed rebasing issues
jalextowle
added a commit
that referenced
this pull request
Feb 29, 2024
…ed (#783) * Distribute excess idle after collecting zombie interest part-way through a term * Added some testing for zombie collection
jalextowle
added a commit
that referenced
this pull request
Mar 2, 2024
…ed (#783) * Distribute excess idle after collecting zombie interest part-way through a term * Added some testing for zombie collection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors assertions in the short tests in the same way that the refactors in the long tests were performed.