replace get_* with calculate_*
#920
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpaiton
requested review from
jalextowle,
jrhea,
mcclurejt,
ryangoree and
slundqui
as code owners
dpaiton
force-pushed
the
dpaiton/replace-get-calculate
branch
from
85da0f8 to
8acddf3
Compare
jrhea
reviewed
Apr 2, 2024
jrhea
reviewed
Apr 2, 2024
jrhea
reviewed
Apr 2, 2024
jrhea
reviewed
Apr 2, 2024
jrhea
reviewed
Apr 2, 2024
jrhea
approved these changes
Apr 2, 2024
Contributor
jrhea
left a comment
jrhea
left a comment
There was a problem hiding this comment.
im going to go ahead and approve. the only issues are with comments. maybe just grep for get in the comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved Issues
naming convention
Description
I replaced any fn where we calculate something to have the prefix
calculate_instead ofget_per @jrhea 's request.Fns that return state (
get_state();get_pool_info(); etc) are left alone.Review Checklists
None of the checklist items apply; only need a name.
[[Reviewer Name]]