Support initialization of Atom::Generator from hash and block.

History.txt

@@ -2,6 +2,7 @@
 
 * Remove useless variable warning.  (Sam Roberts)
 * Support initialization of Atom::Source from Hash and block.
+* Support initialization of Atom::Generator from Hash and block.
 
 == 0.3.3 2008-04-09
 

lib/atom.rb

@@ -61,16 +61,25 @@ def initialize
   class Generator
     include Xml::Parseable
 
-    attr_reader :name
+    attr_accessor :name
     attribute :uri, :version
 
     # Initialize a new Generator.
     #
     # +xml+:: An XML::Reader object.
     #
-    def initialize(xml)
-      @name = xml.read_string.strip
-      parse(xml, :once => true)
+    def initialize(o = nil)
+      case o
+      when XML::Reader
+        @name = o.read_string.strip
+        parse(o, :once => true)
+      when Hash
+        o.each do |k, v|
+          self.send("#{k.to_s}=", v)
+        end
+      end
+
+      yield(self) if block_given?
     end
   end
 

spec/atom_spec.rb

@@ -1153,5 +1153,26 @@
       source.title.should == 'title'
       source.id.should == 'sourceid'
     end      
-  end  
+  end
+
+  describe Atom::Generator do
+    it "should create an empty generator" do
+      lambda { Atom::Generator.new }.should_not raise_error
+    end
+
+    it "should create from a hash" do
+      source = Atom::Generator.new(:name => 'generator', :uri => 'http://generator')
+      source.name.should == 'generator'
+      source.uri.should == 'http://generator'
+    end
+
+    it "should create from a block" do
+      source = Atom::Generator.new do |source|
+        source.name = 'generator'
+        source.uri = 'http://generator'
+      end
+      source.name.should == 'generator'
+      source.uri.should == 'http://generator'
+    end
+  end
 end