Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved some time formatting codes #22556

Conversation

spearmin10
Copy link
Contributor

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

N/A

Description

Some code improvement for time formatters

Minimum version of Cortex XSOAR

  • 6.0.0
  • 6.1.0
  • 6.2.0
  • 6.5.0

Does it break backward compatibility?

  • Yes
    • Further details:
  • No

Must have

  • Tests
  • Documentation

@content-bot content-bot added the Contribution Thank you! Contributions are always welcome! label Nov 29, 2022
@content-bot content-bot changed the base branch from master to contrib/spearmin10_TimeComponents November 29, 2022 04:21
@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @omerKarkKatz will know he can start review the proposed changes.

@content-bot content-bot added Community Contribution Form Filled Whether contribution form filled or not. labels Nov 29, 2022
Copy link
Contributor

@omerKarkKatz omerKarkKatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@spearmin10 Thanks you very much for your contribution it looks good!
I will approve this change.

@omerKarkKatz omerKarkKatz merged commit e6e3318 into demisto:contrib/spearmin10_TimeComponents Nov 29, 2022
omerKarkKatz pushed a commit that referenced this pull request Nov 29, 2022
Co-authored-by: Masahiko Inoue <54964121+spearmin10@users.noreply.github.com>
@spearmin10 spearmin10 deleted the TimeComponents branch December 2, 2022 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome!
Projects
None yet
3 participants