Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for unknown relationship names #22564

Merged
merged 31 commits into from Dec 11, 2022
Merged

Added support for unknown relationship names #22564

merged 31 commits into from Dec 11, 2022

Conversation

MLainer1
Copy link
Contributor

@MLainer1 MLainer1 commented Nov 29, 2022

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

A few sentences describing the overall goals of the pull request's commits.

Screenshots

Paste here any images that will help the reviewer

Minimum version of Cortex XSOAR

  • 6.0.0
  • 6.1.0
  • 6.2.0
  • 6.5.0

Does it break backward compatibility?

  • Yes
    • Further details:
  • No

Must have

  • Tests
  • Documentation

@MLainer1 MLainer1 marked this pull request as ready for review November 29, 2022 15:36
@MLainer1 MLainer1 changed the title Added support for unknown relationship types Added support for unknown relationship names Nov 30, 2022
Copy link
Contributor

@JudahSchwartz JudahSchwartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice`1 Couple documentation questions

@xsoar-bot
Copy link
Contributor

@MLainer1 MLainer1 merged commit e87a534 into master Dec 11, 2022
@MLainer1 MLainer1 deleted the TIM_Indicators branch December 11, 2022 15:15
ShahafBenYakir pushed a commit that referenced this pull request Dec 11, 2022
* Added support for unknown relationship types

* fix validations

* fix test

* remove exceptions when uknown RelName is used

* reverse name for unknown rel name

* mypy

* Update 1_31_40.md

* better debug message

* located-at relation

* Update 1_31_41.md

* remove unsupported filter

* pack metadata

* flake8

* cr

* added test

* flake8

* cve dbot score

* dockec=rimage

* DOCKERIMAGE AGAIN
efelmandar pushed a commit that referenced this pull request Jan 4, 2023
* Added support for unknown relationship types

* fix validations

* fix test

* remove exceptions when uknown RelName is used

* reverse name for unknown rel name

* mypy

* Update 1_31_40.md

* better debug message

* located-at relation

* Update 1_31_41.md

* remove unsupported filter

* pack metadata

* flake8

* cr

* added test

* flake8

* cve dbot score

* dockec=rimage

* DOCKERIMAGE AGAIN
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Jan 11, 2023
* Added support for unknown relationship types

* fix validations

* fix test

* remove exceptions when uknown RelName is used

* reverse name for unknown rel name

* mypy

* Update 1_31_40.md

* better debug message

* located-at relation

* Update 1_31_41.md

* remove unsupported filter

* pack metadata

* flake8

* cr

* added test

* flake8

* cve dbot score

* dockec=rimage

* DOCKERIMAGE AGAIN
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants