New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for unknown relationship names #22564
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MLainer1
changed the title
Added support for unknown relationship types
Added support for unknown relationship names
Nov 30, 2022
JudahSchwartz
approved these changes
Nov 30, 2022
JudahSchwartz
approved these changes
Dec 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice`1 Couple documentation questions
Packs/FeedMitreAttackv2/Integrations/FeedMitreAttackv2/FeedMitreAttackv2.py
Outdated
Show resolved
Hide resolved
Packs/FeedMitreAttackv2/Integrations/FeedMitreAttackv2/FeedMitreAttackv2.py
Outdated
Show resolved
Hide resolved
Link to the unit tests coverage report: |
ShahafBenYakir
pushed a commit
that referenced
this pull request
Dec 11, 2022
* Added support for unknown relationship types * fix validations * fix test * remove exceptions when uknown RelName is used * reverse name for unknown rel name * mypy * Update 1_31_40.md * better debug message * located-at relation * Update 1_31_41.md * remove unsupported filter * pack metadata * flake8 * cr * added test * flake8 * cve dbot score * dockec=rimage * DOCKERIMAGE AGAIN
This was referenced Dec 12, 2022
efelmandar
pushed a commit
that referenced
this pull request
Jan 4, 2023
* Added support for unknown relationship types * fix validations * fix test * remove exceptions when uknown RelName is used * reverse name for unknown rel name * mypy * Update 1_31_40.md * better debug message * located-at relation * Update 1_31_41.md * remove unsupported filter * pack metadata * flake8 * cr * added test * flake8 * cve dbot score * dockec=rimage * DOCKERIMAGE AGAIN
xsoar-bot
pushed a commit
to xsoar-contrib/content
that referenced
this pull request
Jan 11, 2023
* Added support for unknown relationship types * fix validations * fix test * remove exceptions when uknown RelName is used * reverse name for unknown rel name * mypy * Update 1_31_40.md * better debug message * located-at relation * Update 1_31_41.md * remove unsupported filter * pack metadata * flake8 * cr * added test * flake8 * cve dbot score * dockec=rimage * DOCKERIMAGE AGAIN
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
fixes: link to the issue
Description
A few sentences describing the overall goals of the pull request's commits.
Screenshots
Paste here any images that will help the reviewer
Minimum version of Cortex XSOAR
Does it break backward compatibility?
Must have