Skip to content

FeedDomainTools Pack Release v1.0.7#44090

Merged
MosheEichler merged 5 commits into
demisto:contrib/DomainTools_domaintools-feeds-v1.0.7from
DomainTools:domaintools-feeds-v1.0.7
Apr 30, 2026
Merged

FeedDomainTools Pack Release v1.0.7#44090
MosheEichler merged 5 commits into
demisto:contrib/DomainTools_domaintools-feeds-v1.0.7from
DomainTools:domaintools-feeds-v1.0.7

Conversation

@briluza
Copy link
Copy Markdown
Contributor

@briluza briluza commented Apr 29, 2026 •
edited by marketplace-content-sync
Loading

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

  • Fixed an issue for domainrisk and domainhotlist feeds where the risk score details are not in rawJSON.

Must have

  • Tests
  • Documentation

relates: https://jira-dc.paloaltonetworks.com/browse/CIAC-16670

@content-bot content-bot added Partner-Approved Contribution Form Filled Whether contribution form filled or not. Partner Contribution Thank you! Contributions are always welcome! External PR Partner Support Level Indicates that the contribution is for Partner supported pack labels Apr 29, 2026
@content-bot content-bot changed the base branch from master to contrib/DomainTools_domaintools-feeds-v1.0.7 April 29, 2026 10:14
@content-bot
Copy link
Copy Markdown
Contributor

content-bot commented Apr 29, 2026

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @kamalq97 will know the proposed changes are ready to be reviewed.
For your convenience, here is a link to the contributions SLAs document.

@content-bot
Copy link
Copy Markdown
Contributor

content-bot commented Apr 29, 2026

Hi @briluza, thanks for contributing to the XSOAR marketplace. To receive credit for your generous contribution please follow this link.

@content-bot
Copy link
Copy Markdown
Contributor

content-bot commented Apr 29, 2026

🤖 AI-Powered Code Review Available

Hi @kamalq97, @MosheEichler, you can leverage AI-powered code review to assist with this PR!

Available Commands:

  • @marketplace-ai-reviewer start review - Initiate a full AI code review
  • @marketplace-ai-reviewer re-review - Incremental review for new commits

@MosheEichler MosheEichler added ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. ready-for-ai-review The PR is ready for reviewing the PR with the AI Reviewer. labels Apr 30, 2026
@content-bot
Copy link
Copy Markdown
Contributor

content-bot commented Apr 30, 2026

For the Reviewer: Trigger build request has been accepted for this contribution PR.

@content-bot
Copy link
Copy Markdown
Contributor

content-bot commented Apr 30, 2026

For the Reviewer: Successfully created a pipeline in GitLab with url: https://gitlab.xdr.pan.local/xdr/cortex-content/content/-/pipelines/8615731

@content-bot content-bot removed the ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. label Apr 30, 2026
@marketplace-ai-reviewer marketplace-ai-reviewer removed the ready-for-ai-review The PR is ready for reviewing the PR with the AI Reviewer. label Apr 30, 2026
@marketplace-ai-reviewer
Copy link
Copy Markdown
Contributor

marketplace-ai-reviewer commented Apr 30, 2026

🤖 Analysis started. Please wait for results...

@marketplace-ai-reviewer
Copy link
Copy Markdown
Contributor

marketplace-ai-reviewer commented Apr 30, 2026

🤖 AI Review Disclaimer

This review was generated by an AI-powered tool and may contain inaccuracies. Please be advised, and we extend our sincere apologies for any inconvenience this may cause.

marketplace-ai-reviewer
marketplace-ai-reviewer reviewed Apr 30, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@marketplace-ai-reviewer marketplace-ai-reviewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thanks for contributing the DomainTools feed integration. I've reviewed your PR and left a few notes to help polish it up. The main things to look at are adding the missing created key and vendor keyword to the pack metadata, as well as aligning a default value in the Python code with your YAML file. Thanks for your work on this!

Additionally, please address the following file-level notes:

  • Packs/FeedDomainTools/pack_metadata.json: - The mandatory key created is missing from pack_metadata.json.
  • The vendor name 'DomainTools' must appear in the keywords array.

@MosheEichler, @kamalq97 please review and approve the results generated by the AI Reviewer by responding 👍 on this comment.

Comment thread Packs/FeedDomainTools/Integrations/FeedDomainTools/FeedDomainTools.py
Comment thread Packs/FeedDomainTools/Integrations/FeedDomainTools/FeedDomainTools.py
@MosheEichler MosheEichler enabled auto-merge (squash) April 30, 2026 14:03
@MosheEichler MosheEichler merged commit 91b0e02 into demisto:contrib/DomainTools_domaintools-feeds-v1.0.7 Apr 30, 2026
103 of 116 checks passed
@content-bot content-bot mentioned this pull request Apr 30, 2026
Merged
5 tasks
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 30, 2026

Thank you for your contribution. Your external PR has been merged and the changes are now included in an internal PR for further review. The internal PR will be merged to the master branch within 3 business days.

MosheEichler added a commit that referenced this pull request May 10, 2026
@content-bot @briluza @MosheEichler
FeedDomainTools Pack Release v1.0.7 (#44140)
f7d4347 
* FeedDomainTools Pack Release v1.0.7 (#44090)

* fix rawJSON for domainrisk and domainhotlist feeds

* update release notes

* Docker

* RN

---------

Co-authored-by: Bri <133698148+briluza@users.noreply.github.com>
Co-authored-by: Moshe Eichler <78307768+MosheEichler@users.noreply.github.com>
Co-authored-by: Moshe Eichler <meichler@paloaltonetworks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marketplace-ai-reviewer marketplace-ai-reviewer marketplace-ai-reviewer left review comments

@MosheEichler MosheEichler MosheEichler approved these changes

@kamalq97 kamalq97 Awaiting requested review from kamalq97

Assignees

@DeanArbel DeanArbel

@kamalq97 kamalq97

Labels

Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! docs-approved External PR Partner Support Level Indicates that the contribution is for Partner supported pack Partner Partner-Approved TIM Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@briluza @content-bot @marketplace-ai-reviewer @MosheEichler @DeanArbel @kamalq97