Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding validation RM108 #4324

Merged
merged 31 commits into from
Jun 13, 2024
Merged

adding validation RM108 #4324

merged 31 commits into from
Jun 13, 2024

Conversation

maimorag
Copy link
Contributor

@maimorag maimorag commented Jun 4, 2024

Related Issues

fixes: https://jira-dc.paloaltonetworks.com/browse/CIAC-10610

Description

This validation verifies the following in README and Description files:

  1. Image links are relative.
  2. Images are saved under "doc_files" folder.

@maimorag maimorag marked this pull request as ready for review June 5, 2024 09:23
Copy link

github-actions bot commented Jun 5, 2024

Changelog(s) in markdown:

  • Converted the RM108 validation to the new format. This validation verifies that images in the readme and description files are relative and stored in doc_files. #4275

Copy link
Contributor

@YuvHayun YuvHayun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! see my comments.

Copy link
Contributor

@YuvHayun YuvHayun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!
minor comments.

maimorag and others added 5 commits June 6, 2024 10:35
Co-authored-by: Yuval Hayun <70104171+YuvHayun@users.noreply.github.com>
Copy link
Contributor

@eyalpalo eyalpalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@maimorag maimorag merged commit 914074e into master Jun 13, 2024
25 checks passed
@maimorag maimorag deleted the Ciac10610 branch June 13, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants