Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note/label fields on download links #15

Open
glennlunder opened this issue Jan 9, 2014 · 6 comments

Comments

@glennlunder
Copy link

commented Jan 9, 2014

(moved over from trac, ticket #120 on there)

To distinguish things like video captures, party vs final releases, disk 1 / disk 2, and so on.

comment from trac ticket by Saga Musix: This has been requested on the forums as well by now. Would be really useful to have. :)

Also discussed with Bombe on irc 2014-01-09.

@sagamusix

This comment has been minimized.

Copy link
Contributor

commented May 1, 2014

On the forums, digi has suggested similar functionality for other external links as well, so that they don't read "WWW" anymore: http://demozoo.org/forums/post/885/#post-885
Might be more difficult to implement and probably not all the necessary, since in the given example it might make more sense to use a "normal" download link anyway.

@glennlunder

This comment has been minimized.

Copy link
Author

commented May 2, 2014

I've given this some thought too. An alternative might be to categorize links that are not recognized, so if you add a link that's not recognized you'd gfet a menu saying "This is not one of our recognized sites, would you care to choose what type of page it is?" and you'd get alternatives for "homepage" "project site", etc. Just a thought.

@gasman gasman added this to the real-soon-now milestone May 23, 2016

@cxw42

This comment has been minimized.

Copy link

commented Sep 11, 2016

@glennlunder I think prompting for a link type for unknown sites makes a lot of sense.

@jensadne

This comment has been minimized.

Copy link
Contributor

commented Apr 12, 2018

Got inspired to test a quick&dirty approach to how to edit these things (since we already have a field in the database to store them..)

link_editing_with_description

@sagamusix

This comment has been minimized.

Copy link
Contributor

commented Apr 12, 2018

Whooo, make it happen! :)

jensadne added a commit to jensadne/demozoo that referenced this issue Jul 13, 2018
@jensadne

This comment has been minimized.

Copy link
Contributor

commented Jul 13, 2018

Have now a working implementation of this, there are however some UI issues that must be figured out before it can be merged.

Right now ul.external_link a has display:block, which means the link description ends up on the next link, and thus it looks like shit.

As for the download links there's a slightly different, but similar, issue in that the link itself is rendered by the as_download_link method in the BaseUrl class, and there we don't have access to all the fields from the model. Not sure how much I'd potentially break by modifying that method so for now I've left the description outside the

tag which obviously also has display:block.

But apart from those issues this has taken so little effort it's almost shameful that it's taken so long for me to get it done.

Any input @gasman or @nswaldman ?

jensadne added a commit to jensadne/demozoo that referenced this issue Jul 20, 2018
jensadne added a commit to jensadne/demozoo that referenced this issue Jul 20, 2018
jensadne added a commit to jensadne/demozoo that referenced this issue Jul 20, 2018
jensadne added a commit to jensadne/demozoo that referenced this issue Jul 20, 2018

@nswaldman nswaldman self-assigned this Jul 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.