Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to parse XML clover files #3

Open
wants to merge 23 commits into
base: master
Choose a base branch
from

Conversation

emibcn
Copy link

@emibcn emibcn commented Jul 16, 2020

I have added:

  • xml2json dependency in package.json. It forces to add dist/build/Release/node_expat.node to the repo
  • TS models for the imported XML
  • A translating function from the XML to the already used coverage-summary.json structure
  • Some tests

I have changed:

  • Default file to parse: coverage/clover.xml
  • Github workflow to generate and parse self coverage test
  • README, action.yml and package.json to reflect repo change and differences

Also, the process has added automatically the coverage badges to .github/badges/ using the results from nuning npm test -- --coverage ;)

It will probably be better to make a generic parser dispatcher and put there the 2 existing parsers and the new ones. Also add an option to let the user force the parser type. Now it's autodetected by file extension: if file name ends with .json, use original, if not, use clover XML parser.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants