Skip to content

add explicit type param to ignore #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 7, 2025
Merged

add explicit type param to ignore #300

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dea9cd2
add explicit type param to ignore
joprice Jan 7, 2025
88717b7
add explicit type param to Option.ignore
joprice Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/FsToolkit.ErrorHandling/Option.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ module Option =
/// </summary>
/// <param name="opt">The option to ignore.</param>
/// <returns>A unit option.</returns>
let inline ignore (opt: 'T option) : unit option =
let inline ignore<'T> (opt: 'T option) : unit option =
match opt with
| Some _ -> Some()
| None -> None
Expand Down
3 changes: 2 additions & 1 deletion src/FsToolkit.ErrorHandling/Task.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,11 @@ module Task =
let inline map3 ([<InlineIfLambda>] f) x y z = apply (map2 f x y) z

/// Allows us to call `do!` syntax inside a computation expression
let inline ignore (x: Task<'a>) =
let inline ignore<'a> (x: Task<'a>) =
x
|> map ignore


/// Takes two tasks and returns a tuple of the pair
let zip (a1: Task<_>) (a2: Task<_>) =
task {
Expand Down