Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prompt "are you sure?" before deleting .next directory with publish init command #2186

Open
2 of 9 tasks
yousefamar opened this issue Jan 16, 2022 · 2 comments
Open
2 of 9 tasks
Labels
good first issue scope.publish Static site generation, sending note links and anything to do with publishing your notes. type.enhancement Extension to a previously shipped feature. Minor functionality update.

Comments

@yousefamar
Copy link

yousefamar commented Jan 16, 2022

Please select if your request is either something new or an enhancement

  • Enhancement of an existing Feature.
  • Request of a new feature.

Please select the area your request applies to. (Multiple selections are Possible. You can leave blank if you're not sure.)

  • Workspace - VSCode workspace, vaults, Intellisense/autocomplete, Dendron settings
  • Lookup - Dendron's Lookup Command
  • Views - Dendron Preview, Tree View, Side Panels in the UI
  • Schema - Dendron Schemas
  • Pod - Data import from / export to Dendron
  • Publish - External Site Publish
  • Markdown - Markdown features, such as syntax support and features

Is your feature request related to a problem? Please describe

I ran dendron publish init absent-mindedly and it deleted an existing .next/ which had some stuff I needed.

Describe the solution you'd like

Would be cool if it didn't automatically delete .next/ or asked you if you're sure (y/n).

Describe alternatives you've considered

-

Additional context

🌱 checking if .next  directory exists.
🌱 .next directory exists
🌱 existing .next directory deleted.
...
@github-actions github-actions bot added scope.publish Static site generation, sending note links and anything to do with publishing your notes. status.triage-needed type.enhancement Extension to a previously shipped feature. Minor functionality update. labels Jan 16, 2022
@SeriousBug
Copy link
Contributor

Thanks for the suggestion. The .next folder is generally "transient" and can be recreated, but I agree that init shouldn't blindly delete it.

@LukeCarrier
Copy link
Member

As a heads up, this behaviour changed in #2162: dendron publish init will now first try to update the existing template, but if that fails the directory will be removed without confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue scope.publish Static site generation, sending note links and anything to do with publishing your notes. type.enhancement Extension to a previously shipped feature. Minor functionality update.
Projects
None yet
Development

No branches or pull requests

4 participants