feat:Random Note Command #813
Conversation
|
|
jonathanyeung
force-pushed
the
feature-random-note
branch
from
1075b56
to
dbe0087
Compare
packages/plugin-core/package.json
Outdated
| @@ -1,752 +1,757 @@ | |||
| { | |||
| "name": "@dendronhq/plugin-core", | |||
There was a problem hiding this comment.
Oops - did we do some 'prettier' or whitespace formatting changes recently to this file? The only material difference should be the addition of
{
"command": "dendron.randomNote",
"title": "Dendron: Random Note",
"desc": "Open a Random Note"
},
There was a problem hiding this comment.
yeah, we did some formatting. no worries about this
There was a problem hiding this comment.
is it ok to merge as is? or would you prefer me to re-align to the whitespace changes currently in master?
There was a problem hiding this comment.
can you update the package generation code? specifically this should be changed to 2 spaces
packages/plugin-core/package.json
Outdated
| @@ -1,752 +1,757 @@ | |||
| { | |||
| "name": "@dendronhq/plugin-core", | |||
There was a problem hiding this comment.
yeah, we did some formatting. no worries about this
|
|
||
| type CommandInput = {}; | ||
|
|
||
| type CommandOutput = void; |
There was a problem hiding this comment.
a convention we've been following is to return the note as an output. makes it easy to test
There was a problem hiding this comment.
cool, will adjust
| } | ||
|
|
||
| let isMatch = false; | ||
|
|
There was a problem hiding this comment.
nitpick: prefer forEach syntax for conciseness. eg. includeSet.forEach( pattern => { ... } )
There was a problem hiding this comment.
Hmm - doesn't seem like you can call break from within an interable.forEach() loop though: https://stackoverflow.com/questions/2641347/short-circuit-array-foreach-like-calling-break
There was a problem hiding this comment.
ah, good catch. in that case, feel free to use for or use _.some (we make liberal use of lodash as our utility library) https://lodash.com/docs/#some
| } from "../testUtilsV3"; | ||
|
|
||
| // common template function for RandomNoteCommand testing | ||
| function basicTest( |
There was a problem hiding this comment.
prefer object notation for function argument for readability. see https://wiki.dendron.so/notes/773e0b5a-510f-4c21-acf4-2d1ab3ed741e.html#prefer-using-object-notation-for-methods-ith-multiple-arguments
There was a problem hiding this comment.
Sorry, new to Typescript - when I tried to switch to object notation, the parameters can no longer be referenced within runLegacyMultiWorkspaceTest(). Seems that the properties of opts aren't known in that context (Error is Object literal may only specify known properties, and 'opts' does not exist in type 'SetupCodeConfigurationV2...
There was a problem hiding this comment.
hmm... how did you do it? it should look like the following:
basicTest({ctx, preSetupHook, ...}: {
ctx: ...
preSetupHook: ...
})There was a problem hiding this comment.
I see what you mean now - adjusted
| ctx, | ||
| preSetupHook: async ({ wsRoot, vaults }) => { | ||
| for (let name of noteNames) { | ||
| await CreateNoteFactory({ fname: name, body: "" }).create({ |
There was a problem hiding this comment.
instead of exporting note factoring, you can use NoteTestUtilsV4
There was a problem hiding this comment.
cool, will adjust and remove the export.
Fixes #743
New Command to navigate to a random note.