Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it possible to not load "font-awesome" #41

Closed
cavo789 opened this issue Oct 3, 2017 · 2 comments
Closed

Is it possible to not load "font-awesome" #41

cavo789 opened this issue Oct 3, 2017 · 2 comments

Comments

@cavo789
Copy link

cavo789 commented Oct 3, 2017

Hi Greg

Thanks for this great plugin !

When using it, the debug console show me a 404 request to "my_site/reveal.js-menu/font-awesome-4.3.0/css/font-awesome.min.css" and, indeed, I've not take that subdirectory because I already load font-awesome elsewhere in my application.

My question : is it possible to have an option to specify "No, don't try to load the font" ?

The line https://github.com/denehyg/reveal.js-menu/blob/master/menu.js#L16 seems to force the loading.

Thanks !

@denehyg
Copy link
Owner

denehyg commented Oct 3, 2017

I've added a loadIcons option in the dev branch (ca1f9f9). Just set loadIcons: false within the menu options in your presentation and the menu will not try to load font-awesome for itself.

@denehyg denehyg closed this as completed Oct 3, 2017
@cavo789
Copy link
Author

cavo789 commented Oct 4, 2017

Wonderfull ! Fast answer and great solution ! Tested and approved ;)

Thanks Greg.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants