New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MediaGalleryプラグインを少し改善しました #14

Open
wants to merge 7 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@mystralkk

mystralkk commented Oct 15, 2017

getid3()ライブラリを最新版に差し替え、PHP 7.1, MySQLのutf8mb4文字セットでエラーになっていた箇所を修正しました。

@eSilverStrike

This comment has been minimized.

eSilverStrike commented Oct 19, 2017

Didn't get far in testing. Tried to install your pull request for the PHP 7 fix on my development version of Geeklog which the database uses the utf8mb4 collation. It doesn't like the index for the gl_mg_playback_options table. Looks like there is another issue to deal with as well.

`
E_USER_ERROR(256) - 1071: Specified key was too long; max key length is 767 bytes @ C:\inetpub\GitHub\geeklog\system\databases\mysqli.class.php line 459
Call Stack

1 | trigger_error | C:\inetpub\GitHub\geeklog\system\databases\mysqli.class.php | 459
2 | dbQuery | C:\inetpub\GitHub\geeklog\system\lib-database.php | 216
3 | DB_query | C:\inetpub\GitHub\geeklog\public_html\admin\plugins.php | 1114
4 | plugin_do_autoinstall | C:\inetpub\GitHub\geeklog\public_html\admin\plugins.php | 1017
5 | plugin_autoinstall | C:\inetpub\GitHub\geeklog\public_html\admin\plugins.php | 1364

array(5) {
["sql"]=>
string(327) "CREATE TABLE gl_mg_playback_options (
media_id varchar(40) NOT NULL default '',
option_name varchar(210) NOT NULL default '',
option_value varchar(255) NOT NULL default '',
UNIQUE KEY media_id_2 (media_id,option_name),
KEY media_id (media_id)
) ENGINE=InnoDB ROW_FORMAT=DYNAMIC DEFAULT CHARSET=utf8mb4"
["ignore_errors"]=>
int(0)
["p"]=>
int(269)
["option"]=>
string(57) " ENGINE=InnoDB ROW_FORMAT=DYNAMIC DEFAULT CHARSET=utf8mb4"
["result"]=>
bool(false)
`

@eSilverStrike

This comment has been minimized.

eSilverStrike commented Oct 19, 2017

Okay I added the issue with utf8mb4 to dengen media gallery repository with the proposed fixes.

For your version bump to 1.7.1 you also need to modify the line 55 in function.inc

$_MG_CONF['pi_version'] = '1.7.0';

and then everything installs correctly. I did a limited test with PHP 7.0 and didn't run into any errors

While looking at the Media Gallery upgrade function I notice the upgrade.php file is missing so I am not to sure how close to release version 1.7.0 is.

I also uploaded an image and had a few issues. (not related to your pull request)

That being said it looks like this Pull Request fixes the PHP 7 issues. Hopefully Dengen will merge it soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment