Mixed comments and snippets in search mode

[SamuelDSR]

Issue Description

Environment

• System: Ubuntu18.04
• Installation method: linuxbrew

When search a snippet, the comments and commands of all candidate snippet are interleved in a random way.
Please see snapshot below :)

[welcome]

Thanks for opening your first issue here! In case you're facing a bug, please update navi to the latest version first. Maybe the bug is already solved! :)

[wallace11]

Yeah I agree too that this is very confusing. We already have the preview window so maybe we can have the list show only desc / only command and the preview show the other one (should be configurable imho).

[denisidoro]

Actually, it's not displayed randomly. It shows "best" matches in descending order, according to fzf.

I'm not sure about displaying only comments or only snippets because many people (myself included) search by both, depending on the use. An option could be added to filter these results, but that would limit the use of the cheatsheets and I believe only a few people would really use it.

Any other ideas?

[denisidoro]

Ah, one important info: there's no way to hide the snippets and search for them, for example. fzf requires it to be visible printed to be searchable

[denisidoro]

One can use the hidden ANSI code to hide some content, but that won't work on most terminal emulators

[wallace11]

Yeah, you have a point there
Maybe it's possible to put the command/comment on the same line with muted color next to category.
It's almost certainly going to overflow but fzf auto-calculates that and we have the preview to compensate.

[denisidoro]

Yeah, I'm thinking on something like

change branch  [git]  git checkout
get logs       [git]  git logs
reset          [git]  git reset

[denisidoro]

Some quick experiments:

[denisidoro]

I believe the width of a given column should be limited otherwise all the other content will become invisible. I'm not sure if we should use magic numbers or make if dependent on the terminal width.

[denisidoro]

WDYT?

[denisidoro]

This way it will become impossible to read the whole comment if it's too big, though

[denisidoro]

The preview could always contain 2 lines: one for the comment and another one for the snippet :)

[denisidoro]

[wallace11]

Last one looks superb.
If you provided the full echo command I can paste here more examples of how it looks.

[denisidoro]

I'm about to open a PR so you can test it using another branch 👍

[denisidoro]

@SamuelDSR and @wallace11: could you try the table/refactor branch and give your feedback?

[SamuelDSR]

@SamuelDSR and @wallace11: could you try the table/refactor branch and give your feedback?

The branch table/refactor works perfectly in search mode under both mac iterm2/ ubuntu bash [tested]. Thanks very much. @denisidoro

[denisidoro]

Cool! The branch introduces new options to customize which columns are shown and so on. I'll probably merge it this week